[OAK-930] VersionManager#isCheckedOut throws IllegalStateException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9
• Component/s: core, jcr
• Assignee: Marcel Reutegger
• Reporter: Angela Schreiber
• Created: 24/Jul/13 14:24
• Updated: 20/Sep/13 07:01
• Resolved: 05/Aug/13 12:16

Description

the currently implementation of VersionManager#isCheckedOut will throws
IllegalStateException if the node at the specified path is not versionable and the root node is not accessible to the editing session.

the issue is caused by the implementation of ReadOnlyVersionManager#isCheckedOut
which looks as follows:

if (checkNotNull(tree).exists()) {
            PropertyState p = tree.getProperty(VersionConstants.JCR_ISCHECKEDOUT);
            if (p != null) {
                return p.getValue(Type.BOOLEAN);
            } else if (tree.isRoot()) {
                return true;
            }
        } else {
            // FIXME: this actually means access to the tree is restricted
            // and may result in wrong isCheckedOut value. This should never
            // be the case in a commit hook because it operates on non-access-
            // controlled NodeStates. This means consistency is not at risk
            // but it may mean oak-jcr sees a node as checked out even though
            // it is in fact read-only because of a checked-in ancestor.
        }
        // otherwise return checkedOut status of parent
        return isCheckedOut(tree.getParent());

in fact: in case of the failing calling the code hits the FIXME.
IMHO the underlying problem is caused by the fact that the versionmanager operates on the access controlled tree instances instead of relying on low level NodeState or ImmutableTree.

i will commit a test case illustrating the problem.

Issue Links

• blocks: OAK-168 Basic JCR VersionManager support