[OAK-8948] ObservationManager.addEventListener() throws NPE with invalid paths in filter

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.17, 1.8.20
• Fix Version/s: 1.26.0, 1.22.10
• Component/s: jcr
• Labels: Observation
• Assignee: Marcel Reutegger
• Reporter: rafiya sirin
• Created: 11/Mar/20 09:31
• Updated: 13/Sep/23 08:05
• Resolved: 13/Mar/20 15:09

Description

While registering a resource change listener, we encountered the following exception : 

 

05.03.2020 23:39:00.728 *ERROR* [FelixDispatchQueue] org.apache.sling.resourceresolver FrameworkEvent ERROR (java.lang.NullPointerException)
java.lang.NullPointerException: null
at org.apache.jackrabbit.oak.commons.PathUtils.unifyInExcludes(PathUtils.java:501) [org.apache.jackrabbit.oak-commons:1.8.17]
at org.apache.jackrabbit.oak.jcr.observation.ObservationManagerImpl.addEventListener(ObservationManagerImpl.java:240) [org.apache.jackrabbit.oak-jcr:1.8.17]
at org.apache.sling.jcr.resource.internal.JcrListenerBaseConfig.register(JcrListenerBaseConfig.java:136) [org.apache.sling.jcr.resource:3.0.16.1]

 

On further debugging, we found that issues lies in this snippet : 

if (exclude.equals(include) || isAncestor(exclude, include)) {
 includesRemoved.add(include);

'exclude' can be null if the getOakPath() method returns a null. This NPE causes listeners(ResourceChangeListener in our case) to fail at registration.

Issue Links

• links to: GitHub Pull Request #196
• links to: GitHub Pull Request #462