[OAK-8896] API withDomainOverrideIgnored doesn't match the implementation of BinaryUploadOptions

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.24.0
• Component/s: api
• Assignee: Unassigned
• Reporter: Jun Zhang
• Created: 07/Feb/20 23:35
• Updated: 07/Feb/20 23:35

Description

the new API withDomainOverrideIgnored though, it's named as withDomainOverrideIgnored for both BinaryDownloadOptions and BinaryUploadOptions per documentation, but it's `withDomainOverrideIgnore` in the implementation of BinaryUploadOptions class, it missed a ending d in the method name for BinaryUploadOptions,

The document is wrong ATM and the API name doesn't match with each other, making change over that or just leave with it and fix the document?
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/binary/BinaryUploadOptions.java#L96 https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/binary/BinaryDownloadOptions.java#L325Doc:
https://jackrabbit.apache.org/oak/docs/features/direct-binary-access.html