Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-8888

Disable lazy Lucene index file loading in 1.22 branch (flip default)

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.22.1
    • lucene
    • None

    Description

      Switch the default for "oak.lucene.nonLazyIndex".

      Attachments

        1. OAK-8888.diff
          0.7 kB
          Julian Reschke

        Issue Links

          Activity

            ngupta Nitin Gupta added a comment -

            reschke - in this case, if someone actually sets the property oak.lucene.nonLazyIndex = true in system properties and would expect there should not be any lazy index loading - but the system would behave otherwise.

            ngupta Nitin Gupta added a comment - reschke - in this case, if someone actually sets the property oak.lucene.nonLazyIndex = true in system properties and would expect there should not be any lazy index loading - but the system would behave otherwise.
            ngupta Nitin Gupta added a comment -
            Index: oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java
            ===================================================================
            --- oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java	(revision 1873416)
            +++ oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java	(working copy)
            @@ -192,7 +192,7 @@
             public class LucenePropertyIndex extends FulltextIndex {
             
             
            -    private static boolean NON_LAZY = Boolean.getBoolean("oak.lucene.nonLazyIndex");
            +    private static boolean NON_LAZY = Boolean.parseBoolean(System.getProperty("oak.lucene.nonLazyIndex","true"));
             
                 private static double MIN_COST = 2.1;
            

            This should suffice I suppose. wdyt ?

            ngupta Nitin Gupta added a comment - Index: oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java =================================================================== --- oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java (revision 1873416) +++ oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java (working copy) @@ -192,7 +192,7 @@ public class LucenePropertyIndex extends FulltextIndex { - private static boolean NON_LAZY = Boolean .getBoolean( "oak.lucene.nonLazyIndex" ); + private static boolean NON_LAZY = Boolean .parseBoolean( System .getProperty( "oak.lucene.nonLazyIndex" , " true " )); private static double MIN_COST = 2.1; This should suffice I suppose. wdyt ?
            reschke Julian Reschke added a comment -

            Good point.

            reschke Julian Reschke added a comment - Good point.
            reschke Julian Reschke added a comment -

            ngupta - do you want to take this one? I believe this is the last thing missing for 1.22.1.

            reschke Julian Reschke added a comment - ngupta - do you want to take this one? I believe this is the last thing missing for 1.22.1.
            ngupta Nitin Gupta added a comment - Fixed here - https://svn.apache.org/viewvc?view=revision&revision=1873517 cc : thomasm  

            People

              ngupta Nitin Gupta
              reschke Julian Reschke
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: