Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-8365

UserManagerImpl: unreacheable code when retrieving user/group from ID and tree

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.14.0
    • Component/s: core, security
    • Labels:
      None

      Description

      when retrieving user/group by id or tree the user mgr implementation will verify that the id associated with a given tree actually is of type authorizable and return null if that's not the case. consequently, line 437 in UserManagerImpl will never be reached.

      Alex Deparvu, i will refactor the code such that the ID lookup is limited to one single place in getAuthorizable(Tree) and drop the extra if, which will not be reached.

        Attachments

          Activity

            People

            • Assignee:
              angela Angela Schreiber
              Reporter:
              angela Angela Schreiber
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: