Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-8365

UserManagerImpl: unreacheable code when retrieving user/group from ID and tree

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.14.0
    • core, security
    • None

    Description

      when retrieving user/group by id or tree the user mgr implementation will verify that the id associated with a given tree actually is of type authorizable and return null if that's not the case. consequently, line 437 in UserManagerImpl will never be reached.

      Alex Deparvu, i will refactor the code such that the ID lookup is limited to one single place in getAuthorizable(Tree) and drop the extra if, which will not be reached.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            angela Angela Schreiber
            angela Angela Schreiber
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment