[OAK-8266] Redundant check for existing tree in CompiledPermissionImpl.buildVersionDelegatee

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.14.0
• Component/s: core, security
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 23/Apr/19 12:45
• Updated: 11/Jun/19 10:51
• Resolved: 26/Apr/19 12:47

Description

stillalex, i found that the check for existence of the passed tree in CompiledPermissionImpl.buildVersionDelegatee is redundant, due to the while loop just before calling the method. line 204ff:

                        while (!versionableTree.exists()) {
                            versionableTree = versionableTree.getParent();
                        }
                        return new VersionTreePermission(tree, buildVersionDelegatee(versionableTree), providerCtx.getTreeProvider());

and subsequently:

private TreePermission buildVersionDelegatee(@NotNull Tree versionableTree) {
        if (!versionableTree.exists()) {
            return TreePermission.EMPTY;
        } else if (versionableTree.isRoot()) {
            return createRootPermission(versionableTree);
        } 
        [...]
}

due to the loop the method buildVersionDelegatee either gets an existing tree or the root tree. IMO we should remove that extra if (see attached patch). wdyt?