Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-8185

Improve CompositeNodeStore fixture

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.10.3, 1.14.0
    • Component/s: benchmarks
    • Labels:
      None

      Description

      While working on OAK-8141 I noticed the benchmark numbers for GetDeepNodeTest on Oak-Composite-Store are rather low compared to Oak-Segment-Tar.

      Apache Jackrabbit Oak 1.12-SNAPSHOT
      # GetDeepNodeTest                  C     min     10%     50%     90%     max       N 
      Oak-Segment-Tar                    1      35      37      39      41      64    1524
      Oak-Composite-Store                1     203     204     208     214     236     288
      

      In an offline conversation Tomek Rękawek mentioned the overhead shouldn't be that big because the implementation should switch to the non-composite implementation as soon as the read operation traverses into the global/writable node store. It seems however, this is not the case when running GetDeepNodeTest. So, this may well be a bug and not an improvement, as filed at the moment.

        Attachments

        1. composite-node-builder.txt
          2 kB
          Tomek Rękawek
        2. OAK-8185-update-fixture.patch
          1 kB
          Tomek Rękawek

          Activity

            People

            • Assignee:
              tomek.rekawek Tomek Rękawek
              Reporter:
              mreutegg Marcel Reutegger
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: