[OAK-8035] Debug logging when two or more indices have same or very close cost amounts doesn't work in case both indices belong to the same type of Query Index

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Component/s: query
• Labels: indexingPatch
• Assignee: Julian Reschke
• Reporter: Nitin Gupta
• Created: 08/Feb/19 09:17
• Updated: 23/Jan/23 01:58
• Resolved: 15/Feb/19 19:27

Description

Steps to reproduce -

1. You would need two index definitions of same query index type , let's say fullText index , having similar cost evaluations.
2. Now while the index plan is evaluated you will notice that there should have been a debug log saying that selected index has similar cost - this serves as an important warning to either change the index definitions or the query (https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java#L1069#L1072)

 

However If we have a look at this code block here - https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java#L1017#L1041 , there is no comparison for near best costs for index plans having same query index type .

 

cc : teofili

Issue Links

• relates to: OAK-7795 Log a debug message when two or more indices have same or very close cost amounts
• links to: GitHub Pull Request #120