[OAK-7919] Imporove logging for ExternalLoginModule.java

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Resolved
• Component/s: auth-external
• Assignee: Unassigned
• Reporter: Antonio Sanso
• Created: 26/Nov/18 12:01
• Updated: 01/Oct/20 14:15
• Resolved: 01/Oct/20 14:15

Description

It would be nice to improve the logging in the ExternalLoginModule.java class

In particular IMHO it would be better to increase the log level in this snippet

        } catch (LoginException e) {
            log.debug("IDP {} throws login exception for '{}': {}", idp.getName(), logId, e.getMessage());
            throw e;
        } catch (Exception e) {
            log.debug("SyncHandler {} throws sync exception for '{}'", syncHandler.getName(), logId, e);
            LoginException le = new LoginException("Error while syncing user.");
            le.initCause(e);
            throw le;
        }

See https://github.com/apache/jackrabbit-oak/blob/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java#L254

Issue Links

• is fixed by: OAK-8102 LoginModule error metrics