Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-7843

oak-upgrade doesn't correctly pass segment cache size to file store

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.10.0, 1.9.10
    • upgrade
    • None

    Description

      When setting a segment cache size via the --cache SEGMENT_CACHE_SIZE option, oak-upgrade doesn't correctly pass it to the file store, although it correctly logs the value right after start. Below meaningful lines from the log, when trying to set a segment cache of 8GB:

      [...]
      16.10.2018 17:00:29.834 [main] *INFO*  org.apache.jackrabbit.oak.upgrade.cli.parser.MigrationOptions - Cache size: 8192 MB
      [..]
      16.10.2018 17:00:30.144 [main] *INFO*  org.apache.jackrabbit.oak.segment.file.FileStore - Creating file store FileStoreBuilder{version=1.10-SNAPSHOT, directory=repository/segmentstore, blobStore=org.apache.jackrabbit.oak.upgrade.cli.blob.LoopbackBlobStore@33b37288, maxFileSize=256, segmentCacheSize=256, stringCacheSize=256, templateCacheSize=64, stringDeduplicationCacheSize=15000, templateDeduplicationCacheSize=3000, nodeDeduplicationCacheSize=1048576, memoryMapping=false, gcOptions=SegmentGCOptions{paused=false, estimationDisabled=false, gcSizeDeltaEstimation=1073741824, retryCount=5, forceTimeout=60, retainedGenerations=2, gcType=FULL}}
      

      It can be observed that the segment cache size remained at 256MB (default).

      Attachments

        1. OAK-7843.patch
          3 kB
          Andrei Dulceanu

        Activity

          People

            adulceanu Andrei Dulceanu
            adulceanu Andrei Dulceanu
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: