Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-7356

CugConfiguration may not pick up CugExclude

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

      Description

      It seems that the CugConfiguration may under some circumstances not properly pick up the CugExclude, which results in the CugConfiguration falling back to the default, that only excludes the AdminPrincipal, SystemPrincipal and SystemUserPrincipals from CUG evaluation.

      In order to address the issue without disrupting the default setup, I would like to propose the following changes:

      • CugConfiguration: Change reference cardinality of the the CugExclude from ReferenceCardinality.OPTIONAL_UNARY to ReferenceCardinality.MANDATORY_UNARY
      • CugExcludeImpl: Don't require an explicit configuration (i.e. drop ConfigurationPolicy.REQUIRE). Since it extends from CugExclude.Default the default behavior in absense of a configured set of principal names will be equivalent to the intended default in CugConfiguration with the optional reference.

        Attachments

        1. OAK-7356.patch
          12 kB
          Angela Schreiber
        2. OAK-7356-2.patch
          14 kB
          Angela Schreiber

          Activity

            People

            • Assignee:
              angela Angela Schreiber
              Reporter:
              angela Angela Schreiber

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment