[OAK-7356] CugConfiguration may not pick up CugExclude

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.9.0, 1.10.0, 1.8.3, 1.6.11
• Component/s: authorization-cug
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 19/Mar/18 14:43
• Updated: 09/Apr/18 03:37
• Resolved: 22/Mar/18 09:05

Description

It seems that the CugConfiguration may under some circumstances not properly pick up the CugExclude, which results in the CugConfiguration falling back to the default, that only excludes the AdminPrincipal, SystemPrincipal and SystemUserPrincipals from CUG evaluation.

In order to address the issue without disrupting the default setup, I would like to propose the following changes:

• CugConfiguration: Change reference cardinality of the the CugExclude from ReferenceCardinality.OPTIONAL_UNARY to ReferenceCardinality.MANDATORY_UNARY
• CugExcludeImpl: Don't require an explicit configuration (i.e. drop ConfigurationPolicy.REQUIRE). Since it extends from CugExclude.Default the default behavior in absense of a configured set of principal names will be equivalent to the intended default in CugConfiguration with the optional reference.