[OAK-7158] Users shouldn't be able to change the number of retained generations

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.9.0, 1.10.0, 1.8.1
• Component/s: segment-tar
• Epic Link: TarMK GC scalability
• Assignee: Francesco Mari
• Reporter: Francesco Mari
• Created: 15/Jan/18 14:42
• Updated: 04/Oct/19 17:49
• Resolved: 16/Jan/18 12:47

Description

Currently, SegmentGCOptions implements a validation check on the number of retained generations that prevents callers to set it to a value smaller than two. Instead, some subsystems might benefit from having a number of retained generations smaller than two - see OAK-7157 as an example.

The check performed by SegmentGCOptions should be moved to SegmentNodeStoreService to prevent users from setting the number of retained generations to a an invalid value. Internal subsystems should be allowed to set the number of retained generations to a lower value, if needed.

Issue Links

• blocks: OAK-7157 Minimize the amount of generations retained by the Cold Standby
• is depended upon by: OAK-7132 SNFE after full compaction