Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-7064

Remove duplicated code from the FileStore logging implementation

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.14, 1.8.0
    • Component/s: segment-tar
    • Labels:
      None

      Description

      The FileStore follows some implicit guidelines when it comes to its logging messages, e.g. prefixing every message with the GC cycle number, and outputting times and sizes both in a human readable and machine readable way.

      These guidelines are implemented ad-hoc, by appropriately crafting each log message individually. This approach leads to clutter and duplicated code. It would be beneficial to the internal quality of the FileStore if all these concerns were instead implemented in a centralised way.

        Attachments

        1. OAK-7064-01.patch
          39 kB
          Francesco Mari
        2. OAK-7064-02.patch
          39 kB
          Francesco Mari

          Activity

            People

            • Assignee:
              frm Francesco Mari
              Reporter:
              frm Francesco Mari
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: