[OAK-6637] Release IndexNode lock in finally clause

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.7.7, 1.6.6, 1.8.0
• Component/s: lucene
• Assignee: Chetan Mehrotra
• Reporter: Chetan Mehrotra
• Created: 08/Sep/17 08:50
• Updated: 22/Sep/17 05:56
• Resolved: 08/Sep/17 08:54

Description

IndexNode currently makes 2 call in release

        @Override
        public void release() {
            if (released.compareAndSet(false, true)) {
                //Decrement on each release
                decrementSearcherUsageCount(holder.searcher);
                IndexNodeManager.this.release();
            }
        }

Its possible that decrementSearcherUsageCount can throw exception and in that case lock would not be released leading to situation as seen in OAK-6619.

As a fix the lock should be released in finally

Issue Links

• relates to: OAK-6635 IndexReader closed exception in DocumentQueue