[OAK-6503] Active deletion of blobs tries to delete sub-16k inlined blobs in case of seg-tar

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.7.1
• Fix Version/s: 1.7.6, 1.8.0
• Component/s: lucene
• Assignee: Vikas Saurabh
• Reporter: Vikas Saurabh
• Created: 28/Jul/17 10:06
• Updated: 25/Aug/17 04:30
• Resolved: 31/Jul/17 13:20

Description

OakDirectory#deleteFile registers a blob as deleted for actively purged even if blob.getContentIdentity is null [0]. That leads to active purge trying to purge an inlined blob and hitting a bening warn in the log (and of course a perf issue to "find" that the blob couldn't really be purged)

[0]:
https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.7.1/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/OakDirectory.java#L168-L173

                    String blobId = b.getContentIdentity();
                    if (blobId == null) {
                        blobId = b.toString();
                    }
                    blobDeletionCallback.deleted(blobId,
                            Lists.newArrayList(definition.getIndexPath(), dataNodeName, name));

Issue Links

• is broken by: OAK-2808 Active deletion of 'deleted' Lucene index files from DataStore without relying on full scale Blob GC
• relates to: OAK-6504 Active deletion of blobs needs to indicate information about purged blobs to mark-sweep collector