[OAK-6461] Merge all security related validators into a single hook

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.5, 1.8.0
• Component/s: core, security
• Assignee: Alex Deparvu
• Reporter: Alex Deparvu
• Created: 18/Jul/17 08:46
• Updated: 08/Jan/18 13:36
• Resolved: 21/Jul/17 08:18

Description

I'd like to see if it's feasible to merge all security related validators into a single hook, instead of a hook per SecurityConfiguration.
Pros

• all validators will be merged into a single hook, meaning processing will happen via a single diff over the content
  Cons
• order of hooks will change, there will be commit hooks first, all aggregated validators next and post validation hooks last. I don't think there's any issue with validation itself as all data added by the hooks will be visible to the composite validator.

This is how the chaining looks like in the current setup:

    EditorHook : 
        (TokenValidatorProvider),
    VersionablePathHook, 
    EditorHook : 
        (CompositeEditorProvider : ([
            PermissionStoreValidatorProvider, 
            PermissionValidatorProvider, 
            AccessControlValidatorProvider])), 
    EditorHook : 
        (PrivilegeValidatorProvider), 

    EditorHook : 
        (CompositeEditorProvider : ([
            UserValidatorProvider,
            CacheValidatorProvider])),
    PermissionHook, 
    JcrAllCommitHook

If we merged them, this is the result:

    VersionablePathHook, 
    EditorHook : 
        (CompositeEditorProvider : ([
            PermissionStoreValidatorProvider,
            PermissionValidatorProvider,
            AccessControlValidatorProvider, 
            UserValidatorProvider,
            CacheValidatorProvider, 
            PrivilegeValidatorProvider,
            TokenValidatorProvider])),
    PermissionHook, 
    JcrAllCommitHook