[OAK-6413] FileCache getIfPresent doesn't update cache hit/miss counters

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.6.1
• Fix Version/s: 1.7.4, 1.6.3, 1.8.0
• Component/s: blob
• Assignee: Amit Jain
• Reporter: Ioan-Cristian Linte
• Created: 03/Jul/17 14:40
• Updated: 17/Jul/17 13:56
• Resolved: 10/Jul/17 06:30

Description

FileCache.getIfPresent bypasses cache access if key is not in cache and CacheStats for "DataStore-DownloadCache" MBean will always have 100% hit rate even when Blobs will be downloaded from the BlobStore backend by AbstractSharedCachingDataStore because of the miss in the cache.

I suggest the following change:
FileCache.getIfPresent to call CacheLIRS.getIfPresent which will update the cache stats (miss and hit counters).