[OAK-6304] Cyclic dependency between oak.spi.query an oak.query.*

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.2, 1.8.0
• Component/s: core, indexing, query
• Epic Link: Modularisation of Oak
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 02/Jun/17 14:11
• Updated: 08/Oct/19 15:22
• Resolved: 13/Jun/17 11:20

Description

while working on OAK-6069 i noticed that there exist IMO troublesome dependencies from o.a.j.oak.spi.query back to o.a.j.oak.query.*. While i don't know the historical reasons that led to this setup it feels wrong to me that the interfaces and classes in o.a.j.oak.spi.query would have dependencies to packages that from my understanding are supposed to contain implementations.

while utilities like o.a.j.oak.spi.query.Cursors may simply have ended up in the wrong bucket and could possibly moved to e.g o.a.j.query.index, i couldn't find an easy solution for an interface like o.a.j.oak.spi.query.Filter that defines methods returning o.a.j.query.fulltext.FullTextExpression and o.a.j.query.QueryEngineSettings, while at the same time being tied to the o.a.j.oak.spi.query.QueryIndex interface.

Issue Links

• breaks: OAK-6790 FacetResult class isn't exposed anymore
• is related to: OAK-6355 Usage of NodeAggregator creates cyclic dependency between oak.spi.query and oak.plugins.index.*
• is related to: OAK-6319 Review API and Utilities in oak.plugins.tree package
• is related to: OAK-6343 Add replacement for deprecated RootFactory.createSystemRoot