Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-6301

Make QueryEngineSettingsMBeanImpl an inner class of o.a.j.oak.Oak

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.7.1, 1.8.0
    • core, query
    • None

    Description

      looking at the query code base in the light of OAK-6069 i came across o.a.j.oak.query.QueryEngineSettingsMBeanImpl wondering why we have 2 implementations of the QueryEngineSettingsMBean interface in the same package. While QueryEngineSettings is widely used across the oak code base the QueryEngineSettingsMBeanImpl has a single usage in the o.a.j.oak.Oak helper class.

      tmueller explained me the reason for having this additional implementation (instead of having just a single one). however, i would suggest to make QueryEngineSettingsMBeanImpl an inner class of the Oak helper and thus ensure that it's not used mistakenly or causes extra confusion (as it did for me )

      Attachments

        Activity

          People

            angela Angela Schreiber
            angela Angela Schreiber
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: