Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-6295

Move constants from oak.query.QueryImpl to oak.spi.query.QueryConstants

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.7.2, 1.8.0
    • core, query
    • None

    Description

      in the light of the modularisation effort i had a look at the query code and noticed that the constants defined on QueryImpl are needed outside of the scope of the query implementation.

      IMO that indicates that those constants are of broader use and might better be located at oak.spi.query.QueryConstants. moving would in fact remove all imports of QueryImpl in the oak-lucene module.

      tmueller, teofili, it will attach a proposed patch for this improvement and would appreciate if you could review if you are ok with that change.

      Attachments

        1. OAK-6295.patch
          41 kB
          Angela Schreiber

        Issue Links

          is related to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. OAK-6069 Modularisation of Oak

          • Major - Major loss of function.
          • Open

          Activity

            People

              Unassigned Unassigned
              angela Angela Schreiber
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: