[OAK-6001] Remove unused code from FileStore and TarWriter

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0, 1.8.0
• Component/s: segment-tar
• Assignee: Francesco Mari
• Reporter: Francesco Mari
• Created: 29/Mar/17 12:46
• Updated: 30/May/17 08:37
• Resolved: 31/Mar/17 14:38

Description

FileStore.GarbageCollector#collectBulkReferences looks into the currently active TarWriter for references. At the time this method is invoked, the currently active TarWriter is always empty.

Slightly before inspecting the TarWriter, FileStore#newWriter is called to flush the content of the current TarWriter and to create a fresh one. For this reason, inspecting the TarWriter in FileStore.GarbageCollector#collectBulkReferences is unnecessary - the graph of the TarWriter is always empty. Those lines of code can be safely removed.