[OAK-5878] SplitDocumentCleanup iterates twice over splitDocGarbage

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0, 1.6.2, 1.4.19, 1.8.0
• Component/s: documentmk
• Epic Link: DocumentMK revision GC
• Assignee: Julian Reschke
• Reporter: Julian Reschke
• Created: 02/Mar/17 13:40
• Updated: 16/Feb/21 09:53
• Resolved: 07/Mar/17 13:47

Description

SplitDocumentCleanup currently iterates twice over splitDocGarbage.

NOTE: not the case for Mongo DB, as MongoVersionGCSupport overwrites deleteSplitDocuments().

deleteSplitDocuments() currently iterates over splitDocGarbage to obtain the IDs of the documents to be deleted. Instead, we could just collect the IDs inside disconnect(), the memory requirements would be the same.