[OAK-5753] Consistency check incorrectly fails for broken partial paths

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.7.0, 1.8.0
• Component/s: run, segment-tar
• Labels: tooling
• Assignee: Andrei Dulceanu
• Reporter: Andrei Dulceanu
• Created: 22/Feb/17 09:40
• Updated: 30/May/17 08:38
• Resolved: 28/Feb/17 10:24

Description

To better explain the bug I'll describe the content of the revisions:

1. Valid Revision
   Adds child nodes a, b, c, d, e, f with various properties (blobs included)
2. Invalid Revision
   Adds child node z with some blob properties and then corrupts the NODE record holding z.
   Now when the consistency check is run, it correctly detects that the second revision is broken, marks the path /z as corrupt and then continues checking the first valid revision. Because of a check introduced for OAK-5556 [1], which tries to validate the user provided absolute paths before checking them, the checker tries to check /z in the first revision, where of course it can't find it. Therefore the check incorrectly fails for this revision, although it shouldn't have to.

/cc mduerig, frm