Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-5626

ChangeProcessor doesn't reset 'blocking' flag when items from queue gets removed and commit-rate-limiter is null

    XMLWordPrintableJSON

    Details

      Description

      Following up on conversation at [0]:
      ChangeProcessor#queueSizeChanged [1] sets blocking flag to true if queue size is hit (or beyond). The warning "Revision queue is full. Further revisions will be compacted." is logged only when it wasn't blocking.

      BUT, when queue empties, blocking flag is reset inside if block for commitRateLimiter!=null. That means an event chain like:

      1. qFull
      2. log warn
      3. qEmpties
      4. qFull

      won't log the WARN after step(4)

      [0]: http://markmail.org/message/hgein5g3ohyjhw5n
      [1]: https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/observation/ChangeProcessor.java#L307

        Attachments

        1. OAK-5626-v3.patch
          12 kB
          Vikas Saurabh
        2. OAK-5626-v2.patch
          12 kB
          Vikas Saurabh
        3. OAK-5626-1.0Branch.patch
          15 kB
          Vikas Saurabh
        4. OAK-5626.patch
          9 kB
          Vikas Saurabh

          Issue Links

            Activity

              People

              • Assignee:
                catholicon Vikas Saurabh
                Reporter:
                catholicon Vikas Saurabh
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: