[OAK-5626] ChangeProcessor doesn't reset 'blocking' flag when items from queue gets removed and commit-rate-limiter is null

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.2.24, 1.4.14, 1.7.0, 1.6.1, 1.8.0
• Component/s: core
• Assignee: Vikas Saurabh
• Reporter: Vikas Saurabh
• Created: 10/Feb/17 12:03
• Updated: 16/Feb/21 09:52
• Resolved: 15/Feb/17 14:17

Description

Following up on conversation at [0]:
ChangeProcessor#queueSizeChanged [1] sets blocking flag to true if queue size is hit (or beyond). The warning "Revision queue is full. Further revisions will be compacted." is logged only when it wasn't blocking.

BUT, when queue empties, blocking flag is reset inside if block for commitRateLimiter!=null. That means an event chain like:

1. qFull
2. log warn
3. qEmpties
4. qFull

won't log the WARN after step(4)

[0]: http://markmail.org/message/hgein5g3ohyjhw5n
[1]: https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/observation/ChangeProcessor.java#L307

Issue Links

• breaks: OAK-5668 Test failure: observation.ObservationQueueFullWarnTest.warnOnRepeatedQueueFull
• requires: OAK-5668 Test failure: observation.ObservationQueueFullWarnTest.warnOnRepeatedQueueFull
• requires: OAK-5663 Improve LogCustomizer to allow filtering on log messages too