[OAK-554] PropertyStates#createProperty ignores namespace mappings when creating states of type NAME and PATH

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.6
• Component/s: core
• Assignee: Michael Dürig
• Reporter: Angela Schreiber
• Created: 11/Jan/13 17:34
• Updated: 06/May/13 15:48
• Resolved: 18/Jan/13 16:22

Description

as far as i saw we use PropertyStates#createProperty to create and
set an OAK property from a given JCR value or a list of JCR values.

this works well for all types of values except for NAME, PATH which
may contain values with remapped namespaces which will not be converted
back to oak-values during the state creation:

     List<String> vals = Lists.newArrayList();
     for (Value value : values) {
         vals.add(value.getString());
     }
     return new MultiGenericPropertyState(name, vals, Type.fromTag(type, true));

if am not mistaken

value.getString()

will return the JCR
representation of the value instead of the oak representation as it
would be needed here.

possible solutions include:

• passing namepathmapper to the create method
• only accept oak Value implementation that allows to retrieve the
  internal representation, which is present in the ValueImpl afaik.