[OAK-5506] reject item names with unpaired surrogates early

• Type: Wish
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.5.18
• Component/s: core, jcr, segment-tar
• Labels: resilience
• Epic Link: Naming Restrictions
• Assignee: Unassigned
• Reporter: Julian Reschke
• Created: 24/Jan/17 14:32
• Updated: 26/May/21 14:53

Description

Apparently, the following node name is accepted:

"foo\ud800"

but a subsequent getPath() call fails:

javax.jcr.InvalidItemStateException: This item [/test_node/foo?] does not exist anymore
    at org.apache.jackrabbit.oak.jcr.delegate.ItemDelegate.checkAlive(ItemDelegate.java:86)
    at org.apache.jackrabbit.oak.jcr.session.operation.ItemOperation.checkPreconditions(ItemOperation.java:34)
    at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.prePerform(SessionDelegate.java:615)
    at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:205)
    at org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112)
    at org.apache.jackrabbit.oak.jcr.session.ItemImpl.getPath(ItemImpl.java:140)
    at org.apache.jackrabbit.oak.jcr.session.NodeImpl.getPath(NodeImpl.java:106)
    at org.apache.jackrabbit.oak.jcr.ValidNamesTest.nameTest(ValidNamesTest.java:271)
    at org.apache.jackrabbit.oak.jcr.ValidNamesTest.testUnpairedSurrogate(ValidNamesTest.java:259)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

(test case follows)

Issue Links

• is blocked by: OAK-7249 segment store: create charset encoding utility that detects malformed input
• is related to: OAK-7261 DocumentStore: inconsistent behaviour for invalid Strings as document ID
• is related to: OAK-7279 segment-tar update from java 7 to java 8 may break persisted names using invalid characters
• is related to: OAK-7196 ValidNamesTest improvements
• is related to: OAK-7220 add benchmark focused on string write performance
• relates to: OAK-3683 BasicDocumentStore.testInterestingStrings failure on MongoDB with Java 8