[OAK-5216] AsyncIndexUpdate: CONCURRENT_UPDATE should contain relevant stacktrace

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.33
• Fix Version/s: 1.5.15, 1.6.0
• Component/s: core
• Assignee: Alex Deparvu
• Reporter: Joerg Hoh
• Created: 02/Dec/16 11:51
• Updated: 16/Feb/17 07:29
• Resolved: 05/Dec/16 14:47

Description

We are currently investigating problems regarding a failing AsyncIndexUpdate. The first error message starts like this:

30.11.2016 11:05:04.172 *WARN* [pool-11-thread-5] org.apache.jackrabbit.oak.plugins.index.AsyncIndexUpdate [async] The index update failed
org.apache.jackrabbit.oak.api.CommitFailedException: OakAsync0001: Concurrent update detected
at org.apache.jackrabbit.oak.plugins.index.AsyncIndexUpdate.<clinit>(AsyncIndexUpdate.java:90)
at org.apache.jackrabbit.oak.Oak.createContentRepository(Oak.java:518)
at com.adobe.granite.repository.impl.SlingRepositoryManager.createRepository(SlingRepositoryManager.java:357)
at com.adobe.granite.repository.impl.SlingRepositoryManager.acquireRepository(SlingRepositoryManager.java:228)
at org.apache.sling.jcr.base.AbstractSlingRepositoryManager.start(AbstractSlingRepositoryManager.java:304)
at com.adobe.granite.repository.impl.SlingRepositoryManager.activate(SlingRepositoryManager.java:205)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at <unknown class>.<unknown method>(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:56)
at java.lang.reflect.Method.invoke(Method.java:620)
at org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:222)
at org.apache.felix.scr.impl.helper.BaseMethod.access$500(BaseMethod.java:37)
at org.apache.felix.scr.impl.helper.BaseMethod$Resolved.invoke(BaseMethod.java:615)
at org.apache.felix.scr.impl.helper.BaseMethod.invoke(BaseMethod.java:499)
at org.apache.felix.scr.impl.helper.ActivateMethod.invoke(ActivateMethod.java:295)
at org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:302)

at that time the application was already running for some hours, this did not happen on startup!

Also the code indicates, that the exception itself is created on creation of the AsyncIndexUpdate service, so the stacktrace does not give any insight under which condition the exception occurred at all. This should be changed in a way, that the stacktrace contains relevant information about the root cause of the exception.