[OAK-5055] o.a.j.o.s.s.RevisionGC returns status that don't comply with the API

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.12
• Fix Version/s: 1.5.13, 1.6.0
• Component/s: core
• Flags: Patch
• Assignee: Timothee Maret
• Reporter: Timothee Maret
• Created: 03/Nov/16 13:37
• Updated: 14/Nov/16 11:35
• Resolved: 03/Nov/16 16:46

Description

According to the API [0], the method RevisionGC#startRevisionGC should

@return  the status of the operation right after it was initiated

However, it does return succeeded on every call, see [1].
I believe this should either compute the actual state, or return initiated or running.

Same applies for cancelRevisionGC.

[0] https://github.com/apache/jackrabbit-oak/blob/18d69e6f590064585414f12bda724f48f3d5843f/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGCMBean.java#L34-L40

[1] https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L105
https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L123