[OAK-5046] Remove the old estimation OSGi setting (compaction.gainThreshold)

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.12
• Fix Version/s: 1.5.13, 1.6.0
• Component/s: segment-tar
• Labels: osgi-config
• Assignee: Andrei Dulceanu
• Reporter: Andrei Dulceanu
• Created: 02/Nov/16 10:19
• Updated: 04/Oct/19 17:52
• Resolved: 07/Nov/16 16:21

Description

Currently, there are two implementations for finding out the gain in repository size after running compaction: the old one, CompactionGainEstimate and the new one, SizeDeltaGcEstimation. Similarly, there are also two configurations for customising them, in SegmentNodeStoreService, compaction.gainThreshold and compaction.sizeDeltaEstimation.

At the moment both of them are exposed as OSGi configurations, but only the new one should be exposed (e.g. compaction.sizeDeltaEstimation).

It must be evaluated whether it makes sense to keep the logic associated with the old implementation.

Issue Links

• is related to: OAK-5058 Improve GC estimation strategy based on both absolute size and relative percentage