Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-4992

Use the role name as prefix for directory used by SegmentNodeStoreFactory

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.5.13, 1.6.0
    • segment-tar, segmentmk
    • None

    Description

      Currently SegmentNodeStoreFactory uses a directory named segmentstore under repository home to store the segment files. To allow easier setup where multiple NodeStore instance do not overstep on each other this name should be prefixed with role

      Note that code tries to do the same currently with logic below but it ends up always creating segmentstore folder under repository home. As a fix role should be used in getDirectory method

          private File getBaseDirectory() {
              String directory = property(DIRECTORY);
      
              if (directory != null) {
                  return new File(directory);
              }
      
              if (role == null) {
                  return new File("tarmk");
              } else {
                  return new File("tarmk-" + role);
              }
          }
      
          private File getDirectory() {
              return new File(getBaseDirectory(), "segmentstore");
          }
      

      Attachments

        Activity

          People

            chetanm Chetan Mehrotra
            chetanm Chetan Mehrotra
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: