[OAK-4813] Simplify the server side of cold standby

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: Segment Tar 0.0.14
• Component/s: segment-tar
• Assignee: Francesco Mari
• Reporter: Andrei Dulceanu
• Created: 15/Sep/16 12:17
• Updated: 10/Oct/16 11:32
• Resolved: 26/Sep/16 09:48

Description

With the changes introduced in OAK-4803, it would be nice to keep the previous symmetry between the client and server and remove thus the FileStore reference from the latter.

Per frm's suggestion from one of the comments in OAK-4803:

In the end, these are the only three lines where the FileStore is used in the server, which already suggests that this separation of concerns exists - at least at the level of the handlers.

p.addLast(new GetHeadRequestHandler(new DefaultStandbyHeadReader(store)));
p.addLast(new GetSegmentRequestHandler(new DefaultStandbySegmentReader(store)));
p.addLast(new GetBlobRequestHandler(new DefaultStandbyBlobReader(store)));

Issue Links

• blocks: OAK-4673 Segment Tar should implement a cold standby functionality