Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-4696

Improve logging for SyncHandler

    XMLWordPrintableJSON

    Details

      Description

      In the ExternalLoginModule.syncUser the context.sync(..) is being called without evaluating the return value at all (https://github.com/apache/jackrabbit-oak/blob/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java#L354). The return value should be logged to find out, which sync took place.

      Also I am wondering if it would make sense to do the root.commit() only conditionally in case the return value is not SyncResult.NOP.

        Attachments

          Activity

            People

            • Assignee:
              baedke Manfred Baedke
              Reporter:
              kwin Konrad Windszus
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: