[OAK-4696] Improve logging for SyncHandler

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.8
• Fix Version/s: 1.2.23, 1.4.12, 1.5.14, 1.6.0
• Component/s: auth-external
• Assignee: Manfred Baedke
• Reporter: Konrad Windszus
• Created: 24/Aug/16 09:45
• Updated: 30/Jan/17 20:20
• Resolved: 28/Oct/16 13:59

Description

In the ExternalLoginModule.syncUser the context.sync(..) is being called without evaluating the return value at all (https://github.com/apache/jackrabbit-oak/blob/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java#L354). The return value should be logged to find out, which sync took place.

Also I am wondering if it would make sense to do the root.commit() only conditionally in case the return value is not SyncResult.NOP.