Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-4616

Record suggestor status in suggest-data node

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.5.7, 1.6.0
    • lucene
    • None

    Description

      Currently the suggestor storage logic maintains a timestamp of when suggestor data was last updated in property lastUpdated in :suggesterStatus node. Actual suggest data is stored in a separate node :suggest-data.

      /oak:index/lucene-suggest: { reindexCount = 1, name = lucene-suggest, compatVersion = 2, reindex = false, type = lucene, jcr:primaryType = oak:QueryIndexDefinition, :facet-config = { ... }, indexRules = { ... }, :data = { ... }, :status = { ... }, :suggest-data = { ... }, :suggesterStatus = { ... }}
      

      It would be better if this property is stored in :suggest-data. This would simplify adding support for multiplexing as each dir node would be having complete info

      + :oak:mount-foo-suggest-data
         - lastUpdated
      + :suggest-data
         - lastUpdated
      

      Attachments

        1. OAK-4616-v1.patch
          2 kB
          Chetan Mehrotra

        Issue Links

          Activity

            patch for the same

            catholicon Can you have a look. It does not check for backward compatibility so for upgraded system there would be a slight hit that first index post Oak version update would trigger suggestor index update. But that should be ok

            chetanm Chetan Mehrotra added a comment - patch for the same catholicon Can you have a look. It does not check for backward compatibility so for upgraded system there would be a slight hit that first index post Oak version update would trigger suggestor index update. But that should be ok
            catholicon Vikas Saurabh added a comment -

            Yes, makes sense and looks good to me. Although, I'm trying to recall why did I make a separate node in the first place :-/.

            catholicon Vikas Saurabh added a comment - Yes, makes sense and looks good to me. Although, I'm trying to recall why did I make a separate node in the first place :-/.

            Done in trunk with 1754484

            chetanm Chetan Mehrotra added a comment - Done in trunk with 1754484

            Bulk close for 1.5.7

            edivad Davide Giannella added a comment - Bulk close for 1.5.7

            People

              chetanm Chetan Mehrotra
              chetanm Chetan Mehrotra
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: