[OAK-4613] Suggest directory should be opened in read only mode

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.5.7, 1.6.0
• Component/s: lucene
• Assignee: Chetan Mehrotra
• Reporter: Chetan Mehrotra
• Created: 28/Jul/16 11:11
• Updated: 04/Aug/16 13:15
• Resolved: 28/Jul/16 11:12

Description

IndexNode currently opens the suggest directory in following way

 if (definition.isSuggestEnabled()) {
      suggestDirectory = new OakDirectory(defnNodeState.builder(), ":suggest-data", definition, false);
}

It has two issues

• It open a builder on existing node state. Instead of that it should use ReadOnlyBuilder
• The directory should be opened in read only mode