[OAK-4591] Clarify implementation and documentation of TarReader#mark

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Segment Tar 0.0.8
• Component/s: segment-tar
• Labels: cleanup gc
• Assignee: Michael Dürig
• Reporter: Michael Dürig
• Created: 22/Jul/16 13:09
• Updated: 02/Aug/16 12:45
• Resolved: 22/Jul/16 13:14

Description

There is a few peculiarities with that method:

• The Javadoc "A bulk segment is reclaimable if it is in bulkRefs" is wrong. It should be "A bulk segment is reclaimable if it is not in bulkRefs".
• (Why) is it necessary to iterate in reverse over the entries in tar file?
• Why the extra check for bulk references in the else branch?
• The condition !reclaim.remove(id) is always true as id can only be in reclaim it it had been added in the same iteration (as ids are unique). But this would have been in the if branch, contradicting us being in the else branch.