Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-4224

DefaultSyncContext.sync(ExternalIdentity) should verify IDP

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      while writing more test for DefaultSyncContext i realized that the implementation of sync(ExternalIdentity) doesn't verify that the given external identity belongs to the same IDP than the one associated with the context instance.

      IMHO this would be needed and useful particularly when multiple IDPs are combined. also, the DefaultSyncContext is a public exposed class, I would prefer if it would guard against mixing up sync of external identities from different sources.

      Attachments

        1. OAK-4224_2.patch
          4 kB
          Angela Schreiber
        2. OAK-4224.patch
          14 kB
          Angela Schreiber

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            angela Angela Schreiber
            angela Angela Schreiber
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment