[OAK-4224] DefaultSyncContext.sync(ExternalIdentity) should verify IDP

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.2.19, 1.4.7, 1.5.2, 1.6.0
• Component/s: auth-external
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 18/Apr/16 17:02
• Updated: 15/Dec/16 01:46
• Resolved: 21/Apr/16 14:51

Description

while writing more test for DefaultSyncContext i realized that the implementation of sync(ExternalIdentity) doesn't verify that the given external identity belongs to the same IDP than the one associated with the context instance.

IMHO this would be needed and useful particularly when multiple IDPs are combined. also, the DefaultSyncContext is a public exposed class, I would prefer if it would guard against mixing up sync of external identities from different sources.