[OAK-4096] Limit the number of times a LuceneResultRow based iterator get reset

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.5.15, 1.6.0
• Component/s: lucene
• Assignee: Thomas Mueller
• Reporter: Chetan Mehrotra
• Created: 08/Mar/16 04:16
• Updated: 08/Oct/19 15:22
• Resolved: 22/Nov/16 13:39

Description

With changes done in OAK-2569 it can happen that the cursor returned by LucenePropertyIndex gets reset multiple times as the index gets updated for a long running query

11697: 26.02.2016 16:12:16.296 *DEBUG* [qtp567069427-14229] org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndex ... took 3690 ms
47507: 26.02.2016 16:13:26.744 *DEBUG* [qtp567069427-14229] org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndex loading the next 12800 entries for query :fulltext:foo
47513: 26.02.2016 16:13:30.486 *DEBUG* [qtp567069427-14229] org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndex ... took 3742 ms
55832: 26.02.2016 16:15:43.693 *DEBUG* [qtp567069427-14229] org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndex loading the next 25600 entries for query :fulltext:foo
55835: 26.02.2016 16:15:51.261 *DEBUG* [qtp567069427-14229] org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndex ... took 7568 ms
59383: 26.02.2016 16:21:12.355 *DEBUG* [qtp567069427-14229] org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndex Change in index version detected 4186634 => 4186631. Query would be performed without offset
59384: 26.02.2016 16:21:12.355 *DEBUG* [qtp567069427-14229] org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndex loading the first 51200 entries for query :fulltext:foo

If the index continuously gets updated then such a query would never finish and would consume system resources. For such case we should enforce some limit

Issue Links

• is cloned by: OAK-5925 CLONE - Limit the number of times a LuceneResultRow based iterator get reset
• relates to: OAK-2569 LuceneIndex#loadDocs can throw IllegalArgumentException