[OAK-4089] The standby store shouldn't start the observation subsystem

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0, 1.6.0
• Component/s: tarmk-standby
• Assignee: Francesco Mari
• Reporter: Francesco Mari
• Created: 03/Mar/16 18:28
• Updated: 10/Nov/16 09:35
• Resolved: 07/Mar/16 12:29

Description

The current implementation of SegmentNodeStore unconditionally instantiates a ChangeDispatcher referencing the root node of the repository at the time of instantiation.

When this occurs in the context of the standby store, the ChangeDispatcher is never notified for changes in the repository content, and the initial repository root is permanently referenced by the ChangeDispatcher. This prevents many segments from being correctly cleaned up from the standby store.

It would be more appropriate not to instantiate the observation subsystem at all in the context of the standby store, thus preventing spurious references to SegmentId instances to float in memory.

Issue Links

• is related to: OAK-4883 Missing BlobGarbageCollection MBean on standby instance
• is superceded by: OAK-4093 Backport OAK-4089 to the 1.4 branch