Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-4054

FileStore.containsSegment returns alway true (almost)

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Won't Fix
    • None
    • None
    • segmentmk

    Description

      FileStore.containsSegment() looks funky. This "optimisation" causes it to always return true.

      containsSegment is used for deduplication and revision gc. The current implementation causes SNFE exceptions once gc is effective (as I experienced while working on OAK-3348).

      Attachments

        Issue Links

        is blocked by

        Improvement - An improvement or enhancement to an existing feature or task. OAK-4256 CLONE - Cross gc sessions might introduce references to pre-compacted segments

        • Critical - Crashes, loss of data, severe memory leak.
        • Resolved

        Improvement - An improvement or enhancement to an existing feature or task. OAK-3348 Cross gc sessions might introduce references to pre-compacted segments

        • Critical - Crashes, loss of data, severe memory leak.
        • Closed
        is cloned by

        Bug - A problem which impairs or prevents the functions of the product. OAK-4255 CLONE - FileStore.containsSegment returns alway true (almost)

        • Critical - Crashes, loss of data, severe memory leak.
        • Closed
        relates to

        Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. OAK-2849 Improve revision gc on SegmentMK

        • Major - Major loss of function.
        • Closed

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mduerig Michael Dürig
            mduerig Michael Dürig
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment