[OAK-3843] MS SQL doesn't support more than 2100 parameters in one request

• Type: Technical task
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.2.10, 1.3.13
• Fix Version/s: 1.0.29, 1.2.11, 1.3.14, 1.4
• Component/s: rdbmk
• Assignee: Julian Reschke
• Reporter: Tomek Rękawek
• Created: 07/Jan/16 09:30
• Updated: 17/Mar/16 17:41
• Resolved: 18/Jan/16 14:22

Description

Following exception is thrown if the RDBDocumentStoreJDBC.read() method is called with more than 2100 keys:

com.microsoft.sqlserver.jdbc.SQLServerException: The incoming request has too many parameters. The server supports a maximum of 2100 parameters. Reduce the number of parameters and resend the request.
	at com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDatabaseError(SQLServerException.java:216) ~[sqljdbc4.jar:na]
	at com.microsoft.sqlserver.jdbc.SQLServerStatement.getNextResult(SQLServerStatement.java:1515) ~[sqljdbc4.jar:na]
	at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.doExecutePreparedStatement(SQLServerPreparedStatement.java:404) ~[sqljdbc4.jar:na]
	at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement$PrepStmtExecCmd.doExecute(SQLServerPreparedStatement.java:350) ~[sqljdbc4.jar:na]
	at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:5696) ~[sqljdbc4.jar:na]
	at com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:1715) ~[sqljdbc4.jar:na]
	at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeCommand(SQLServerStatement.java:180) ~[sqljdbc4.jar:na]
	at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeStatement(SQLServerStatement.java:155) ~[sqljdbc4.jar:na]
	at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.executeQuery(SQLServerPreparedStatement.java:285) ~[sqljdbc4.jar:na]
	at org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStoreJDBC.read(RDBDocumentStoreJDBC.java:593) ~[oak-run-1.4-SNAPSHOT.jar:1.4-SNAPSHOT]
	at org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.readDocumentsUncached(RDBDocumentStore.java:387) [oak-run-1.4-SNAPSHOT.jar:1.4-SNAPSHOT]

The parameters are already split into multiple in clauses, so I think we need to split it further, into multiple queries (if the MS SQL is used). This also applied to other places where we use the RDBJDBCTools.createInStatement().