[OAK-3523] DefaultSyncContext catches ClassCastException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.19, 1.3.9, 1.4
• Component/s: auth-external
• Labels: technical_debt
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 15/Oct/15 15:41
• Updated: 18/Aug/16 13:18
• Resolved: 29/Oct/15 10:08

Description

the group and group-member sync code in the DefaultSyncContext twice catches ClassCastException and swallows exception situations, where a user is found, when actually a Group was expected.

i would suggest to

• explicitly test the assumption wrt ExternalIdentity being a group (instead of waiting for the exception)
• make use of UserManager.getAuthorizable(String, Class) to explicitly retrieve a Group with a given ID, when this is actually expected. This method will throws an {{AuthorizableTypeException if there exists a User with that ID as thus properly raise the unexpected behavior instead of swallowing with a log-warning.

Issue Links

• is cloned by: OAK-3563 Improve DefaultSyncContext