Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-3494

MemoryDiffCache should also check parent paths before falling to Loader (or returning null)

    XMLWordPrintableJSON

Details

    Description

      Each entry in MemoryDiffCache is keyed with (path, fromRev, toRev) for the list of modified children at path. A diff calcualted by DocumentNodeStore.diffImpl at '/' (passively via loader) or JournalEntry.applyTo (actively) fill each path for which there are modified children (including the hierarchy)

      But, if an observer calls compareWithBaseState on a unmodified sub-tree, the observer will still go down to diffImpl although cached parent entry can be used to answer the query.

      Attachments

        1. OAK-3494.patch
          8 kB
          Vikas Saurabh
        2. OAK-3494-1.patch
          7 kB
          Marcel Reutegger
        3. OAK-3494-2.patch
          9 kB
          Vikas Saurabh
        4. OAK-3494-TestCase.patch
          4 kB
          Vikas Saurabh

        Activity

          People

            mreutegg Marcel Reutegger
            catholicon Vikas Saurabh
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: