[OAK-3439] MissingLastRevSeeker potential race condition acquiring the lock

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.23, 1.2.8, 1.3.9
• Fix Version/s: 1.2.11, 1.3.10, 1.4
• Component/s: core, rdbmk
• Assignee: Julian Reschke
• Reporter: Julian Reschke
• Created: 22/Sep/15 13:27
• Updated: 16/Feb/21 09:53
• Resolved: 30/Oct/15 06:39

Description

            // This approach has a race condition where two different cluster
            // nodes
            // can acquire the lock simultaneously.
            UpdateOp update = new UpdateOp(Integer.toString(clusterId), true);
            update.set(ClusterNodeInfo.REV_RECOVERY_LOCK, RecoverLockState.ACQUIRED.name());
            store.createOrUpdate(Collection.CLUSTER_NODES, update);
            return true;

It would be good if could harden this, however it seems that the conditions in UpdateOp only work on revision properties. mreutegg WDYT?

Issue Links

• is blocked by: OAK-3491 DocumentDiscoveryLiteServiceTest makes incorrect call to MissingLastRevRecovery
• is blocked by: OAK-3489 DocumentStore: introduce a "NotEquals" condition
• is related to: OAK-4131 LastRevisionRecoveryAgent may throw ClassCastException
• is related to: OAK-4100 ClusterNodeInfo lease renewal: add logging
• relates to: OAK-3435 LastRevRecoveryAgent/MissingLastRevSeeker improvements