[OAK-3288] clarify DocumentStore contract with respect to number formats

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.19, 1.2.4, 1.3.4
• Fix Version/s: 1.0.21, 1.2.6, 1.3.5, 1.4
• Component/s: core, mongomk, rdbmk
• Labels: resilience
• Epic Link: DocumentMK resilience
• Assignee: Julian Reschke
• Reporter: Julian Reschke
• Created: 25/Aug/15 12:50
• Updated: 26/Sep/19 11:41
• Resolved: 31/Aug/15 12:39

Description

The DS API allows setting properties as java.lang.Integer, but implementations vary in whether they can roundtrip Integers; some do, some convert to Long.

The former is observed for MongoMK (which uses BSON internally), the latter is see in RDBMK (which uses JSON).

We should

• clarify that integers can be set, but they will come back as longs, and
• modify existing implementations to always return longs, so bugs surface early

Issue Links

• is blocked by: OAK-3304 ClusterViewDocument uses Map as property value
• relates to: OAK-3289 ClusterViewDocument should store longs, not integers
• relates to: OAK-3841 Change return type of Document.getModCount() to Long