[OAK-3105] SegmentWriter doesn't properly check the length of external blob IDs

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0.17, 1.2.2, 1.3.2
• Fix Version/s: 1.0.18, 1.2.3, 1.3.3, 1.4
• Assignee: Michael Dürig
• Reporter: Francesco Mari
• Created: 15/Jul/15 08:44
• Updated: 02/Mar/16 11:55
• Resolved: 15/Jul/15 13:57

Description

To store the length field of an external binary ID, the following encoding is used:

1110 + 4bit + 8bit

which allows to store numbers between 0 and 2¹² - 1.

The current implementation of SegmentWriter allows the length of binary IDs to range between 0 and 2¹³ - 1, writing incorrect data when the length of the binary ID ranges from 2¹² to 2¹³ - 1.

When reading this incorrect data back, an IllegalStateException is thrown complaining that the first byte of the length fields has an unexpected value record type. See OAK-1842 for an example.

Issue Links

• blocks: OAK-1842 ISE: "Unexpected value record type: f2" is thrown when FileBlobStore is used