[OAK-2828] Jcr builder class does not allow overriding most of its dependencies

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.2
• Fix Version/s: 1.3.4, 1.4
• Component/s: jcr
• Labels: modularization technical_debt
• Assignee: Alex Deparvu
• Reporter: Robert Munteanu
• Created: 05/May/15 09:14
• Updated: 02/Mar/16 12:06
• Resolved: 12/Aug/15 07:32

Description

The Jcr class is the entry point for configuring a JCR repository using an Oak backend. However, it always use a hardcoded set of dependencies ( IndexEditorProvider, SecurityProvider, etc ) which cannot be reset, as they are defined in the constructor and the builder with methods eagerly configure the backing Oak instance with those dependencies.

As an example

Jcr.java

    @Nonnull
    public final Jcr with(@Nonnull SecurityProvider securityProvider) {
        oak.with(checkNotNull(securityProvider));
        this.securityProvider = securityProvider;
        return this;
    }

injects the security provider which in turn starts configuring the Oak repository provider

Oak.java

    @Nonnull
    public Oak with(@Nonnull SecurityProvider securityProvider) {
        this.securityProvider = checkNotNull(securityProvider);
        if (securityProvider instanceof WhiteboardAware) {
            ((WhiteboardAware) securityProvider).setWhiteboard(whiteboard);
        }
        for (SecurityConfiguration sc : securityProvider.getConfigurations()) {
            RepositoryInitializer ri = sc.getRepositoryInitializer();
            if (ri != RepositoryInitializer.DEFAULT) {
                initializers.add(ri);
            }
        }
        return this;
    }

Instead, the Jcr class should store the configured dependencies and only configure the Oak instance when createRepository is invoked.

Issue Links

• is related to: OAK-2909 Review and improve Oak and Jcr repository setup