[OAK-238] ValueFactory: Missing identifier validation when creating (weak)reference value from String

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.5
• Component/s: jcr
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 13/Aug/12 08:50
• Updated: 01/Oct/12 11:40
• Resolved: 13/Aug/12 09:31

Description

the JCR specification mandates validation of the identifier during
value conversion from STRING to REFERENCE or WEAK_REFERENCE:

<quote from 3.6.4.1 From STRING To)>
REFERENCE or WEAKREFERENCE: If the string is a syntactically valid
identifier, according to the implementation, it is converted directly, otherwise a
ValueFormatException is thrown. The identifier is not required to be that of an
existing node in the current workspace.
<end_quote>

the current ValueFactory implementation in oak-jcr lacks that validation:
creating a REFERENCE or WEAKREFERENCE value using
ValueFactory#createValue(String, int) succeeds even if the specified string
isn't a valid referenceable node identifier.