[OAK-2052] Node.setProperty(String, Value) fails for binary non ValueImpls

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.8, 1.1.0
• Assignee: Michael Dürig
• Reporter: Tobias Bocanegra
• Created: 26/Aug/14 05:54
• Updated: 14/Oct/14 15:28
• Resolved: 28/Aug/14 10:47

Description

JCRVLT-58 reports an issue where "copying" of a JCR value fails,
because the source and destination repository implementation are
different.

so basically:

s1 = repository1.login(); // remote repository via davex
s2 = repository2.login(); // local oak repository

p1 = s1.getProperty(....);
n2 = s2.getNode(....);

n2.setProperty(p1.getName(), p1.getValue());

AFAICT, this usually works but not for binary values. it eventually fails in:

org.apache.jackrabbit.oak.plugins.value.ValueImpl#getBlob(javax.jcr.Value)

    public static Blob getBlob(Value value) {
        checkState(value instanceof ValueImpl);
        return ((ValueImpl) value).getBlob();
    }

...because the value is not a ValueImpl but a QValue.

IMO, this should work, even if the value is not a ValueImpl. In this
case, it should fall back to the API methods to read the binary.

Issue Links

• blocks: JCRVLT-58 VLT RCP errs when moving binary content
• is broken by: OAK-1164 Duplicate binaries