Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-198

Refactor RootImpl#merge

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.4
    • None
    • None

    Description

      IMO the anonymous inner NodeStateDiff implementation created in
      RootImpl#merge method makes the Root implementation quite cumbersome
      to read (the static method has > 150 lines of code while the actual RootImpl
      class just has around 200 lines).

      i would therefore suggest to refactor the code and move the NodeStateDiff
      implementation and the merge method in a separate class.

      Attachments

        Activity

          People

            Unassigned Unassigned
            angela Angela Schreiber
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: