Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-1810

Incorrect TarMK graph metadata validation

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.0
    • 1.0.1, 1.1.0
    • segmentmk
    • None

    Description

      When reading the pre-compiled graph entries from OAK-1780, the TarMK uses a few sanity checks to verify that the graph hasn't been corrupted and that using it for the cleanup operation is safe.

      It turns out that one of these sanity checks (bytes >= count * 24 + 16) is overly strict, as the minimum size limit for the graph entry is instead count * 16 + 16. The "24" factor applies only when checking the sanity of the the tar index entry.

      The effect of this bug is not very critical, as a graph entry that fails the check will just be ignored with a warning and the cleanup code will fall back to the slower algorithm of instead reading the segment graph directly from the stored data segments.

      Attachments

        Activity

          People

            jukkaz Jukka Zitting
            jukkaz Jukka Zitting
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: